[SYCL] Remove manifest from offload binary structure #20748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing abi-breaking changes from intel#20062 Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
requested review from
a team,
aelovikov-intel and
cperkinsintel
as code owners
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
|
||
| // --- Prepare test data | ||
| // - create the first binary image | ||
| // End-to-end test for clang-offload-wrapper executable: |
Contributor
There was a problem hiding this comment.
Is this a copy of clang/test/Driver/clang-offload-wrapper-exe-preview.cpp?
Contributor
Author
There was a problem hiding this comment.
Yes, that's right.
| // RUN: clang-offload-wrapper --help | FileCheck %s --check-prefix CHECK-HELP | ||
| // CHECK-HELP: OVERVIEW: A tool to create a wrapper bitcode for offload target binaries. | ||
| // CHECK-HELP: Takes offload target binaries and optional manifest files as input | ||
| // CHECK-HELP: Takes offload target binaries as input |
Contributor
There was a problem hiding this comment.
This is some strange formatting. Do we need to update the help text somewhere?
Comment on lines
1772
to
1777
| "A tool to create a wrapper bitcode for offload target binaries.\n" | ||
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | ||
| "Takes offload target binaries and optional manifest files as input\n" | ||
| #else | ||
| "Takes offload target binaries as input\n" | ||
| #endif // __INTEL_PREVIEW_BREAKING_CHANGES | ||
| "and produces bitcode file containing target binaries packaged as data\n" | ||
| "and initialization code which registers target binaries in the offload\n" | ||
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | ||
| "runtime. Manifest files format and contents are not restricted and are\n" | ||
| "a subject of agreement between the device compiler and the native\n" | ||
| "runtime for that device. When present, manifest file name should\n" | ||
| "immediately follow the corresponding device image filename on the\n" | ||
| "command line. Options annotating a device binary have effect on all\n" | ||
| #else | ||
| "runtime. Options annotating a device binary have effect on all\n" | ||
| #endif // __INTEL_PREVIEW_BREAKING_CHANGES | ||
| "subsequent input, until redefined.\n" |
Contributor
There was a problem hiding this comment.
Answering my earlier question - we need to reformat this paragraph. I'm not sure what width we're trying to achieve here, but something like this:
"A tool to create a wrapper bitcode for offload target binaries.\n"
"Takes offload target binaries as input and produces bitcode file\n"
"containing target binaries packaged as data and initialization code\n"
"which registers target binaries in the offload runtime. Options\n"
"annotating a device binary have effect on all subsequent input,\n"
"until redefined.\n"
Comment on lines
488
to
490
| { | ||
| std::ofstream File{LockFile}; | ||
| } |
Contributor
There was a problem hiding this comment.
This and below seem unrelated.
Contributor
Author
There was a problem hiding this comment.
Excluded this change.
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Nov 25, 2025
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing abi-breaking changes from #20062
Co-authored-by: Steffen Larsen steffen.larsen@intel.com