Disable llvm-spirv test llvm-intrinsics/memmove.ll#22249
Merged
Conversation
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
Contributor
Author
|
Merging now as build in CI is broken due to this |
sarnex
added a commit
to sarnex/llvm
that referenced
this pull request
Jun 8, 2026
…)" This reverts commit ff6857e.
YuriPlyakhin
reviewed
Jun 8, 2026
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for working on this, @sarnex !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the spirv-val version due to a requirement in the pulldown, and now this test is failing, and we seem to have customization in this test and related source code (71f848c), so disable it for now. If it turns out to be an upstream issue I will file it there.
#22248