Revert llvm-spirv lifetime intrinsic customizations#22253
Draft
sarnex wants to merge 2 commits into
Draft
Conversation
…)" This reverts commit ff6857e.
…anslation (intel#20287)" This reverts commit 71f848c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #20287 and #22249.
The customization was made to handle older GPU Drivers not having the corresponding SPIRV Reader change, but all the drivers we use in CI (even Gen12 Windows) seems to work fine, so we don't need this anymore and it generates SPIR-V that causes
spirv-valto complain, causing us to have to disable a test.CTS run: https://github.com/intel/llvm/actions/runs/27163769503/job/80185619856
Closes: #22248