switch to dynamic gmmlib #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pool request requires the following fixes to be done in gmmlib prior the merge:
@chivakker, @YANGNIN : FYI |
dvrogozh
force-pushed
the
gmmlib_via_pkgconfig
branch
from
9d3390f
to
7e64a53
Compare
dvrogozh
force-pushed
the
gmmlib_via_pkgconfig
branch
2 times, most recently
from
700ac49
to
b28e4a1
Compare
dvrogozh
commented
Aug 14, 2018
There was a problem hiding this comment.
CI will fail because I removed workaround which covered failures of 2 ULT tests. To pass these tests need to apply this change: intel/gmmlib#30
| @@ -20,12 +20,24 @@ | |||
|
|
|||
| project( media ) | |||
|
|
|||
| find_package(PkgConfig) | |||
There was a problem hiding this comment.
re-include with line 78. Please remove line 78 include
dvrogozh
force-pushed
the
gmmlib_via_pkgconfig
branch
3 times, most recently
from
ba91775
to
1f12f13
Compare
dvrogozh
force-pushed
the
gmmlib_via_pkgconfig
branch
from
1f12f13
to
c63210c
Compare
Fixes: intel#277 This change allows ULT tests to fully load/unload the driver. Before the unload driver is checked for the memory leaks. Change-Id: I2ded8630bd516f00b7cce768fcc37b5f47a4e8dc Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com> Signed-off-by: walter-bai <walter.bai@intel.com>
dvrogozh
force-pushed
the
gmmlib_via_pkgconfig
branch
from
c63210c
to
e7ce516
Compare
Sherry-Lin
approved these changes
Aug 24, 2018
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Aug 2, 2022
intel-media-driver-git no longer conflicts with this package. intel-media-driver-git now depends on gmmlib, since it no longer builds gmmlib in-source anymore and also does not install the gmmlib files anymore. References ---------- intel/media-driver#270 intel/media-driver@87fadbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #246, #35
Signed-off-by: Yang, Ning ning.yang@intel.com
Signed-off-by: Dmitry Rogozhkin dmitry.v.rogozhkin@intel.com