Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'verbose' option to logging minimum information #275

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@s1061123
Copy link
Collaborator

s1061123 commented Feb 28, 2019

This change address #274 to add 'verbose option which outputs minimum information (for usual runs with a bit information than 'error').

Following is the example output:

2019-02-28T07:08:21Z [verbose] Add: default:pod-case-01:default-cni-network:eth0 {"cniVersion":"0.3.1","interfaces":[{"name":"cni0","mac":"0a:58:0a:f4:02:01"},{"name":"veth49cb42db","mac":"32:2c:67:42:ea:10"},{"name":"eth0","mac":"0a:58:0a:f4:02:03","sandbox":"/proc/23187/ns/net"}],"ips":[{"version":"4","interface":2,"address":"10.244.2.3/24","gateway":"10.244.2.1"}],"routes":[{"dst":"10.244.0.0/16"},{"dst":"0.0.0.0/0","gw":"10.244.2.1"}],"dns":{}}
2019-02-28T07:08:22Z [verbose] Add: default:pod-case-01:vlan-conf-1-1:net1 {"cniVersion":"0.3.0","interfaces":[{"name":"net1","mac":"52:54:00:12:5b:4e","sandbox":"/proc/23187/ns/net"}],"ips":[{"version":"4","interface":0,"address":"172.16.1.101/24"}],"dns":{}}
2019-02-28T07:09:50Z [verbose] Del: default:pod-case-01:vlan-conf-1-1:net1 {"cniVersion":"0.3.0","ipam":{"addresses":[{"address":"172.16.1.101/24"}],"type":"static"},"master":"eth1","name":"vlan-conf-1-1","type":"vlan","vlanid":1}
2019-02-28T07:09:50Z [verbose] Del: default:pod-case-01:default-cni-network:eth0 { "cniVersion": "0.3.1", "name": "default-cni-network", "plugins": [ { "type": "flannel", "name": "flannel.1", "delegate": { "isDefaultGateway": true, "hairpinMode": true } }, { "type": "portmap", "capabilities": { "portMappings": true } } ] }
Add 'verbose' option to logging minimum information
This change address #274 to add 'verbose option which outputs
minimum information (for usual runs with a bit information than
'error').

@s1061123 s1061123 requested review from dougbtv and rkamudhan Feb 28, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 28, 2019

Pull Request Test Coverage Report for Build 676

  • 22 of 48 (45.83%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 52.773%

Changes Missing Coverage Covered Lines Changed/Added Lines %
logging/logging.go 4 12 33.33%
multus/multus.go 18 36 50.0%
Files with Coverage Reduction New Missed Lines %
multus/multus.go 1 55.2%
Totals Coverage Status
Change from base Build 669: -0.7%
Covered Lines: 609
Relevant Lines: 1154

💛 - Coveralls
@dougbtv

dougbtv approved these changes Mar 6, 2019

Copy link
Member

dougbtv left a comment

LGTM!

@dougbtv dougbtv added the release-v3 label Mar 7, 2019

@dougbtv dougbtv merged commit 61416cb into intel:master Mar 7, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.7%) to 52.773%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

dougbtv added a commit that referenced this pull request Mar 7, 2019

Add 'verbose' option to logging minimum information (#275)
This change address #274 to add 'verbose option which outputs
minimum information (for usual runs with a bit information than
'error').

@dougbtv dougbtv referenced this pull request Mar 7, 2019

Merged

Release v3 updates #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.