Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests to k8sclient.go #357

Merged
merged 15 commits into from Aug 20, 2019

Conversation

@nicklesimba
Copy link
Contributor

commented Aug 12, 2019

Some tests are a WIP and are commented out. Pull request is being made mainly to see new coveralls report but all added tests should be functional.

@nicklesimba nicklesimba changed the title Added tests to k8sclient.go [WIP] Added tests to k8sclient.go Aug 12, 2019

@nicklesimba nicklesimba changed the title [WIP] Added tests to k8sclient.go Added tests to k8sclient.go Aug 13, 2019

@nicklesimba nicklesimba changed the title Added tests to k8sclient.go [WIP] Added tests to k8sclient.go Aug 13, 2019

@nicklesimba nicklesimba changed the title [WIP] Added tests to k8sclient.go Added tests to k8sclient.go Aug 13, 2019

@coveralls

This comment has been minimized.

Copy link

commented Aug 14, 2019

Pull Request Test Coverage Report for Build 846

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.07%) to 74.156%

Totals Coverage Status
Change from base Build 836: 3.07%
Covered Lines: 967
Relevant Lines: 1304

💛 - Coveralls
@s1061123
Copy link
Collaborator

left a comment

Just two minor comments, almost okey to me.
BTW, could you please rebase it (seems to have conflicts). Please use git pull --rebase to resolve conflicts.

})
})

// can't get this test working yet - metadata annotation issue

This comment has been minimized.

Copy link
@s1061123

s1061123 Aug 15, 2019

Collaborator

Could you please add 'TODO', just easy for find.

Expect(err).NotTo(HaveOccurred())
})

// Still figuring this next one out. deals with exponentialBackoff

This comment has been minimized.

Copy link
@s1061123

s1061123 Aug 15, 2019

Collaborator

Could you please add 'TODO', just easy for find.

@nicklesimba nicklesimba force-pushed the nicklesimba:tests branch from 56f64aa to 73ebd20 Aug 19, 2019

@dougbtv dougbtv merged commit 7763f15 into intel:master Aug 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+3.07%) to 74.156%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.