Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UnmarshalJSON() for NetworkSelectionElement #362

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@s1061123
Copy link
Collaborator

commented Aug 21, 2019

To support non-string variable in NetworkSelectionElement, remove
UnmarshalJSON(). interfaceRequest json is still supported in the
changes.

@s1061123 s1061123 requested a review from dougbtv Aug 21, 2019

@dougbtv

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

This looks OK to me, I see some test is failing, I'll fix up the test and merge. Thanks Tomo!

Remove UnmarshalJSON() for NetworkSelectionElement
To support non-string variable in NetworkSelectionElement, remove
UnmarshalJSON(). interfaceRequest json is still supported in the
changes.

@s1061123 s1061123 force-pushed the s1061123:dev/remove-unmarshal branch from ffd3f4d to 70ecd61 Aug 22, 2019

@coveralls

This comment has been minimized.

Copy link

commented Aug 22, 2019

Pull Request Test Coverage Report for Build 853

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 73.516%

Changes Missing Coverage Covered Lines Changed/Added Lines %
k8sclient/k8sclient.go 1 3 33.33%
Totals Coverage Status
Change from base Build 849: -0.6%
Covered Lines: 941
Relevant Lines: 1280

💛 - Coveralls

@dougbtv dougbtv merged commit 05df28a into intel:master Aug 22, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.6%) to 73.516%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@s1061123 s1061123 deleted the s1061123:dev/remove-unmarshal branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.