Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNI Check support #427

Merged
merged 1 commit into from Jan 13, 2020
Merged

Add CNI Check support #427

merged 1 commit into from Jan 13, 2020

Conversation

@mccv1r0
Copy link
Contributor

mccv1r0 commented Dec 23, 2019

Add CNI Check support
Add tests for CNI version 0.4.0

@s1061123 s1061123 self-requested a review Dec 24, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 24, 2019

Pull Request Test Coverage Report for Build 953

  • 62 of 76 (81.58%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 74.024%

Changes Missing Coverage Covered Lines Changed/Added Lines %
multus/multus.go 62 76 81.58%
Totals Coverage Status
Change from base Build 949: 0.8%
Covered Lines: 1043
Relevant Lines: 1409

💛 - Coveralls
Add tests for CNI version 0.4.0
@mccv1r0 mccv1r0 force-pushed the mccv1r0:addCheck branch from ceee4ce to f15339f Jan 10, 2020
@s1061123

This comment has been minimized.

Copy link
Collaborator

s1061123 commented Jan 11, 2020

@mccv1r0 Thank you so much for the PR!! It looks good to me! I'm going to merge it next Monday.

Copy link
Member

dougbtv left a comment

Mike -- thanks a TON for the thorough job on the test cases, that's above and beyond, appreciate it.

@dougbtv dougbtv merged commit c35c4b7 into intel:master Jan 13, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.8%) to 74.024%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.