Skip to content

Conversation

@Kaihui-intel
Copy link
Contributor

@Kaihui-intel Kaihui-intel commented Dec 3, 2025

User description

Type of Change

feature

Description

Directly pass parameters to autoround

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed


PR Type

Enhancement


Description

  • Refactor get_model_info method to return None

  • Update to_config_mapping to directly set configuration

  • Add new tests for static AFP8 export


Diagram Walkthrough

flowchart LR
  A["Refactor get_model_info"] -- "Return None" --> B["Update to_config_mapping"]
  B -- "Set configuration directly" --> C["Add new tests"]
Loading

File Walkthrough

Relevant files
Enhancement
config.py
Refactor model info and config mapping                                     

neural_compressor/torch/quantization/config.py

  • Changed get_model_info to return None
  • Modified to_config_mapping to set configuration directly
+3/-11   

Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
@PRAgent4INC
Copy link
Collaborator

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Issue

The get_model_info method now returns None, which may break any code relying on the previous behavior of returning a list of tuples containing the name and type of each module in the model.

return None
Logic Change

The to_config_mapping method no longer filters modules based on WOQ_WHITE_LIST and logs the model info. This change may affect the configuration mapping logic.

config_mapping = OrderedDict({self.name: self})

@PRAgent4INC
Copy link
Collaborator

PR Code Suggestions ✨

pre-commit-ci bot and others added 2 commits December 3, 2025 07:52
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
@chensuyue chensuyue added this to the 3.7 milestone Dec 3, 2025
Kaihui-intel and others added 6 commits December 3, 2025 16:55
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
@xin3he
Copy link
Contributor

xin3he commented Dec 4, 2025

@Kaihui-intel Please help move the autoround.py from weight_only to a separate folder as we discussed before.

Kaihui-intel and others added 7 commits December 4, 2025 19:48
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
@Kaihui-intel Kaihui-intel requested a review from xin3he December 5, 2025 02:07
pre-commit-ci bot and others added 2 commits December 5, 2025 02:08
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
@XuehaoSun XuehaoSun merged commit 18a29ce into master Dec 5, 2025
23 of 25 checks passed
@XuehaoSun XuehaoSun deleted the kaihui/ar_refactor branch December 5, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants