New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OID Printing changes #7
Conversation
This will be used by an upcoming commit adding a unit test framework. Signed-off-by: Aaron Conole <aconole@redhat.com>
Automake supports using 'make check' to execute so-called unit tests. These are used to do basic sanity checking of the code (prove that it works, etc). This commit introduces an initial user which checks the OID string printed by the mgmt-addr print routine. The test will fail at this point (because there is a bug in the OID print routine). Signed-off-by: Aaron Conole <aconole@redhat.com>
When invoking the lldp tool to view the management information, the display for the OID is printed as the actual binary bits, rather than the OID dotted-notation form. This change will display the OID as expected. Signed-off-by: Aaron Conole <aconole@redhat.com>
|
We are in the process of validating your patch, thank you for your PR! We have tested this on the Mellanox Connectx-4 and Intel X520 with no issues observed. |
|
Ping. Any update? |
|
This has been validated as ready to merge, assigning to Dave to merge. |
|
@praeluceo who should approve this patch? It solves an annoying bug the is recurring on my network. |
|
CVE-2018-10932 was assigned to this issue. |
|
@pedrohc do you have more details on your comment on this PR? Currently 10932 is still reserved: |
|
I have to apologize as I may have overstepped here. I didn't realize you guys were CNA until too late. I can reject the CVE is needed. |
The OID display from lldp-tool is currently dumping the raw bytes from the MIB, rather
than formatting them into a common dotted notation. This series corrects that by displaying
as the common notation.
Additionally, this series incorporates the GNU Autotools 'make check' facility. It introduces a check
in 2/3 which fails, and then fixes the failure in 3/3.
Signed-off-by: Aaron Conole aconole@redhat.com