This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Fix error message in case of unknown criterion value #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krocard
force-pushed
the
Fix_error_message_in_case_of_unknown_criterion_value
branch
from
3f48c6b to
f94b55b
Compare
parameter/SelectionCriterionRule.cpp
Outdated
Contributor
There was a problem hiding this comment.
Are you sure strError is always useless in this context?
I agree that the new error message is far better than the old one, but I am unsure that the strError is always useless in this case.
Maybe we should check all the calls to CSelectionCriterionRule::parse() to ensure strError is always empty/not relevant here
Contributor
Author
There was a problem hiding this comment.
It should be empty as it is an out parameter.
Contributor
There was a problem hiding this comment.
Please add quotes around the string values
Contributor
|
👍 |
When failing to parse a criterion rule, the pfw was outputing: Value error: This did not help to find the root cause. With this patch it would have output: Value error: <Input value> is not part of criterion <Criterion> Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
krocard
force-pushed
the
Fix_error_message_in_case_of_unknown_criterion_value
branch
from
2adebb9 to
2da73a3
Compare
dawagner
added a commit
that referenced
this pull request
Jan 29, 2015
…own_criterion_value Fix error message in case of unknown criterion value
krocard
deleted the
Fix_error_message_in_case_of_unknown_criterion_value
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When failing to parse a criterion rule, the pfw was outputing:
Value error:This did not help to find the root cause.
With this patch it would have output:
Value error: <Input value> is not part of criterion <Criterion>(Of course replacing <*> by the apropriate value)