This repository was archived by the owner on Aug 5, 2022. It is now read-only.
CMake: some modernization #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks nicer linking to that imported library than to
${CMAKE_THREAD_LIBS_INIT}.
Signed-off-by: David Wagner <david.wagner@intel.com>
Current coverage is 48.28%@@ master #368 diff @@
==========================================
Files 211 211
Lines 7169 7169
Methods 1309 1309
Messages 0 0
Branches 3244 3244
==========================================
Hits 3461 3461
Misses 1404 1404
Partials 2304 2304
|
Signed-off-by: David Wagner <david.wagner@intel.com>
dawagner
changed the title
Contributor
Author
| # only public methods instead of the whole class, but they are too many to | ||
| # do that. A separated plugin interface would fix that. | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4 /FIiso646.h -wd4127 -wd4251") | ||
| set_property(DIRECTORY PROPERTY COMPILE_OPTIONS /W4 /FIiso646.h -wd4127 -wd4251) |
Contributor
There was a problem hiding this comment.
Setting this through the add_compile_options function not be cleaner ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linking against Threads::Threads looks nicer linking to that imported library than to
${CMAKE_THREAD_LIBS_INIT}.
Using properties is cleaner than overriding the CMAKE_CXX_FLAGS variable.
Signed-off-by: David Wagner david.wagner@intel.com
@@ master #368 diff @@ ========================================== Files 211 211 Lines 7169 7169 Methods 1309 1309 Messages 0 0 Branches 3244 3244 ========================================== Hits 3461 3461 Misses 1404 1404 Partials 2304 2304add_compile_optionsfunction not be cleaner ?