This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
topic/fix dump element #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use correct blackboard index while calling dumpElement (logValue for ArrayParameter class) to fix the eratic behavior of dumpElement for ArrayParameters. Change-Id: I255af6969283f91cdd2efd810c7d453f3765a16d Tracked-On: Signed-off-by: François Gaffie <francois.gaffie@intel.com>
Accroding to recent testing the dumpElement function is not good for Array. This patch is adding one functional test in Legacy mode in order to cover the issue. Signed-off-by: Sebastien Guiriec <sebastien.guiriec@intel.com>
1 task
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
+ Coverage 74.6% 74.77% +0.17%
==========================================
Files 214 214
Lines 6675 6677 +2
Branches 845 845
==========================================
+ Hits 4980 4993 +13
+ Misses 1224 1212 -12
- Partials 471 472 +1
Continue to review full report at Codecov.
|
cc6565
approved these changes
Apr 7, 2017
cc6565
approved these changes
Apr 7, 2017
cc6565
approved these changes
Apr 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cc6565, @gdenneul, @plbossart, @makohoek Please review. Updated branch with Python legacy test to secure the issue and improve test coverage.
67.33% <100%> (+1.33%)100% <0%> (ø)67.86% <0%> (+0.67%)81.93% <0%> (+0.88%)Continue to review full report at Codecov.