From 1faad4ca1453cff88317a2a803ab6d721864b1b8 Mon Sep 17 00:00:00 2001 From: Luke Valenty Date: Tue, 26 Sep 2023 20:40:27 -0700 Subject: [PATCH 1/3] try intel runners --- .github/workflows/asciidoctor-ghpages.yml | 4 ++-- .github/workflows/unit_tests.yml | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/asciidoctor-ghpages.yml b/.github/workflows/asciidoctor-ghpages.yml index 69fb619..3d945a2 100644 --- a/.github/workflows/asciidoctor-ghpages.yml +++ b/.github/workflows/asciidoctor-ghpages.yml @@ -10,7 +10,7 @@ env: jobs: build: - runs-on: ubuntu-22.04 + runs-on: intel-ubuntu-latest steps: - name: Checkout source @@ -51,7 +51,7 @@ jobs: name: github-pages url: $${{ steps.deployment.outputs.page_url }} - runs-on: ubuntu-22.04 + runs-on: intel-ubuntu-latest steps: - name: Deploy to github pages diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 2567281..d125456 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -21,7 +21,7 @@ concurrency: jobs: build_and_test: - runs-on: ubuntu-22.04 + runs-on: intel-ubuntu-latest strategy: fail-fast: false matrix: @@ -112,7 +112,7 @@ jobs: run: ctest -j $(nproc) -C ${{matrix.build_type}} quality_checks_pass: - runs-on: ubuntu-22.04 + runs-on: intel-ubuntu-latest steps: - uses: actions/checkout@v4 @@ -123,8 +123,8 @@ jobs: - name: Install cmake-format run: | - pip3 install --upgrade pip - pip3 install pyyaml cmake-format + sudo pip3 install --upgrade pip + sudo pip3 install pyyaml cmake-format - name: Configure CMake env: @@ -136,7 +136,7 @@ jobs: run: cmake --build ${{github.workspace}}/build -t quality sanitize: - runs-on: ubuntu-22.04 + runs-on: intel-ubuntu-latest strategy: fail-fast: false matrix: @@ -161,7 +161,7 @@ jobs: run: cmake --build ${{github.workspace}}/build -t unit_tests valgrind: - runs-on: ubuntu-22.04 + runs-on: intel-ubuntu-latest steps: - uses: actions/checkout@v4 @@ -211,7 +211,7 @@ jobs: test $FAILSIZE = "0" merge_ok: - runs-on: ubuntu-22.04 + runs-on: intel-ubuntu-latest needs: [build_and_test, quality_checks_pass, sanitize, valgrind] steps: - name: Enable merge From e04d9a842c8425248afcb5560941c881a51ab0d4 Mon Sep 17 00:00:00 2001 From: Luke Valenty Date: Wed, 27 Sep 2023 15:34:55 -0700 Subject: [PATCH 2/3] use intel-ubuntu-22.04 runners --- .github/workflows/asciidoctor-ghpages.yml | 4 ++-- .github/workflows/unit_tests.yml | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/asciidoctor-ghpages.yml b/.github/workflows/asciidoctor-ghpages.yml index 3d945a2..eed84b5 100644 --- a/.github/workflows/asciidoctor-ghpages.yml +++ b/.github/workflows/asciidoctor-ghpages.yml @@ -10,7 +10,7 @@ env: jobs: build: - runs-on: intel-ubuntu-latest + runs-on: intel-ubuntu-22.04 steps: - name: Checkout source @@ -51,7 +51,7 @@ jobs: name: github-pages url: $${{ steps.deployment.outputs.page_url }} - runs-on: intel-ubuntu-latest + runs-on: intel-ubuntu-22.04 steps: - name: Deploy to github pages diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index d125456..ed889a8 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -21,7 +21,7 @@ concurrency: jobs: build_and_test: - runs-on: intel-ubuntu-latest + runs-on: intel-ubuntu-22.04 strategy: fail-fast: false matrix: @@ -112,7 +112,7 @@ jobs: run: ctest -j $(nproc) -C ${{matrix.build_type}} quality_checks_pass: - runs-on: intel-ubuntu-latest + runs-on: intel-ubuntu-22.04 steps: - uses: actions/checkout@v4 @@ -136,7 +136,7 @@ jobs: run: cmake --build ${{github.workspace}}/build -t quality sanitize: - runs-on: intel-ubuntu-latest + runs-on: intel-ubuntu-22.04 strategy: fail-fast: false matrix: @@ -161,7 +161,7 @@ jobs: run: cmake --build ${{github.workspace}}/build -t unit_tests valgrind: - runs-on: intel-ubuntu-latest + runs-on: intel-ubuntu-22.04 steps: - uses: actions/checkout@v4 @@ -211,7 +211,7 @@ jobs: test $FAILSIZE = "0" merge_ok: - runs-on: intel-ubuntu-latest + runs-on: intel-ubuntu-22.04 needs: [build_and_test, quality_checks_pass, sanitize, valgrind] steps: - name: Enable merge From 1ef07ca933bff915947efc72cb46ccf5ee071b08 Mon Sep 17 00:00:00 2001 From: Luke Valenty Date: Wed, 27 Sep 2023 19:44:38 -0700 Subject: [PATCH 3/3] install pip3 --- .github/workflows/unit_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index ed889a8..57d02a0 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -119,7 +119,7 @@ jobs: - name: Install build tools run: | wget https://apt.llvm.org/llvm.sh && chmod +x llvm.sh && sudo ./llvm.sh ${{env.DEFAULT_LLVM_VERSION}} - sudo apt install -y ninja-build clang-tidy-${{env.DEFAULT_LLVM_VERSION}} clang-format-${{env.DEFAULT_LLVM_VERSION}} + sudo apt install -y python3-pip ninja-build clang-tidy-${{env.DEFAULT_LLVM_VERSION}} clang-format-${{env.DEFAULT_LLVM_VERSION}} - name: Install cmake-format run: |