This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
[doc] Add ARGMAX op. #960
Merged
[doc] Add ARGMAX op. #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huningxin
reviewed
Sep 3, 2019
docs/api.md
Outdated
| @@ -62,6 +62,8 @@ interface NeuralNetworkContext { | |||
| const long MAXIMUM = 65; | |||
| const long ATROUS_CONV_2D = 10003; | |||
| const long ATROUS_DEPTHWISE_CONV_2D = 10004; | |||
| const long ARGMAX = 10005; | |||
| const long ARGMIN = 10006; | |||
There was a problem hiding this comment.
Could you please align the constant value to NNAPI?
const long ARGMAX = 39;
const long ARGMIN = 40;
There was a problem hiding this comment.
Thanks, updated them by the new patch.
huningxin
reviewed
Sep 3, 2019
src/nn/Enums.js
Outdated
| * Outputs: | ||
| * * 0: An (n - 1)-D TENSOR_INT32 tensor. | ||
| */ | ||
| ARGMAX: 10005, |
huningxin
reviewed
Sep 3, 2019
src/nn/Enums.js
Outdated
| * Outputs: | ||
| * * 0: An (n - 1)-D TENSOR_INT32 tensor. | ||
| */ | ||
| ARGMIN: 10006, |
|
Looks good to me. Thanks much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@huningxin @fujunwei These two new ops were referring to ARGMAX and ARGMIN of NN API, please take a review, thanks