Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

[INT-13012] Add tooltip props to dropdown menu section #842

Merged
merged 2 commits into from
Jul 1, 2020
Merged

[INT-13012] Add tooltip props to dropdown menu section #842

merged 2 commits into from
Jul 1, 2020

Conversation

@wyvl
Copy link
Contributor

@wyvl wyvl commented Jul 1, 2020 •
edited
Loading

INT-13012

The following MUST be checked prior to approval. If not relevant to your PR, remove the line from your description.

  • The styleguide.config.js has been updated to show examples/new functionality for the component
  • Test Coverage for any new or updated functionality
  • New and updated components have been tested locally in lapis and SPA and work as expected
  • This PR has been tagged with PATCH, MINOR, or MAJOR.
  • The component has data-component-type and data-component-context attributes following the standard
  • You have requested a cross-team review on this component so everyone knows it exists

@wyvl wyvl added the MINOR Extra functionality with backward compatible changes label Jul 1, 2020
@wyvl wyvl requested a review from a team July 1, 2020 04:29
@wyvl wyvl self-assigned this Jul 1, 2020
@wyvl
Copy link
Contributor Author

wyvl commented Jul 1, 2020

Screen Shot 2020-07-01 at 2 21 33 pm

Screen Shot 2020-07-01 at 2 31 50 pm

Screen Shot 2020-07-01 at 2 31 45 pm

@wyvl wyvl force-pushed the technical/INT-13012-add-tooltip-props-to-dropdown-menu-section branch from d11d7bd to 6e71dec Compare July 1, 2020 04:41
@andrewhillcode andrewhillcode changed the title [INT-13012] Add tooltip props tp dropdown menu section [INT-13012] Add tooltip props to dropdown menu section Jul 1, 2020
andrewhillcode
andrewhillcode previously approved these changes Jul 1, 2020
View reviewed changes
aytee17
aytee17 reviewed Jul 1, 2020
View reviewed changes
@wyvl wyvl force-pushed the technical/INT-13012-add-tooltip-props-to-dropdown-menu-section branch from 348cd04 to 9a9c3a4 Compare July 1, 2020 05:39
aytee17
aytee17 reviewed Jul 1, 2020
View reviewed changes
@wyvl wyvl force-pushed the technical/INT-13012-add-tooltip-props-to-dropdown-menu-section branch from 9a9c3a4 to 1615d33 Compare July 1, 2020 06:30
@wyvl wyvl merged commit 15cd839 into intellihr:develop Jul 1, 2020
@intellibot-access intellibot-access bot mentioned this pull request Jul 2, 2020
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@andrewhillcode andrewhillcode andrewhillcode left review comments

@aytee17 aytee17 aytee17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wyvl wyvl

Labels

MINOR Extra functionality with backward compatible changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wyvl @aytee17 @andrewhillcode