Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

Conversation

@andrewhillcode
Copy link
Contributor

The following MUST be checked prior to approval. If not relevant to your PR, remove the line from your description.

  • The styleguide.config.js has been updated to show examples/new functionality for the component
  • Test Coverage for any new or updated functionality
  • New and updated components have been tested locally in lapis and SPA and work as expected
  • This PR has been tagged with PATCH, MINOR, or MAJOR.
  • The component has data-component-type and data-component-context attributes following the standard
  • You have requested a cross-team review on this component so everyone knows it exists

@andrewhillcode andrewhillcode added the PATCH Bug fixes or improvements with backward compatible changes label Dec 15, 2020
@andrewhillcode andrewhillcode self-assigned this Dec 15, 2020
docs/Language.md Outdated
* **Do**: 8 forms have been scheduled. We'll automatically email the recipients when it's time.
* **Don't**: Successfully scheduled 8 forms.
* **Do**: Goal Template has been enabled.
* **Don't**: Goal Template has been enabled successfully.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specifications for small things like adding phone number or email address or updating or editing similar scenarios.
For now I have used: You've removed/updated/edited your Email Address.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user doesn't need to be told what they've done because they're the ones who did it. It's probably only really appropriate in places where we're also using Your like Your Outstanding Tasks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add more examples and clarification

@KaitlynPickard KaitlynPickard merged commit 163433c into develop Dec 21, 2020
@KaitlynPickard KaitlynPickard deleted the andrewhillcode-patch-1 branch December 21, 2020 07:56
@intellibot-access intellibot-access bot mentioned this pull request Dec 23, 2020
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PATCH Bug fixes or improvements with backward compatible changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants