Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

Conversation

@MichaelDevenish
Copy link
Contributor

@MichaelDevenish MichaelDevenish commented Jan 26, 2021

The following MUST be checked prior to approval. If not relevant to your PR, remove the line from your description.

  • The styleguide.config.js has been updated to show examples/new functionality for the component
  • Test Coverage for any new or updated functionality
  • New and updated components have been tested locally in lapis and SPA and work as expected
  • This PR has been tagged with PATCH, MINOR, or MAJOR.
  • The component has data-component-type and data-component-context attributes following the standard
  • You have requested a cross-team review on this component so everyone knows it exists
    Peek 2021-01-27 13-14

@MichaelDevenish MichaelDevenish added the PATCH Bug fixes or improvements with backward compatible changes label Jan 26, 2021
@MichaelDevenish MichaelDevenish requested review from a team and wyvl January 26, 2021 23:52
@MichaelDevenish MichaelDevenish self-assigned this Jan 26, 2021
Copy link
Contributor

@seanmanson seanmanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a gif of the style of this? I think we need to make it obvious that there's an action when you click it via hover states

@MichaelDevenish MichaelDevenish force-pushed the technical/dont-select-row-when-it-has-on-click branch from 70bf04f to 2674c70 Compare January 27, 2021 01:21
@MichaelDevenish MichaelDevenish force-pushed the technical/dont-select-row-when-it-has-on-click branch from 2674c70 to 5497f17 Compare January 27, 2021 03:24
@MichaelDevenish MichaelDevenish force-pushed the technical/dont-select-row-when-it-has-on-click branch from 5497f17 to 4503e65 Compare January 27, 2021 04:02
@MichaelDevenish MichaelDevenish merged commit 15d45d0 into intellihr:develop Jan 27, 2021
@intellibot-access intellibot-access bot mentioned this pull request Jan 27, 2021
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PATCH Bug fixes or improvements with backward compatible changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants