Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upmore icons #1041
Conversation
This comment has been minimized.
This comment has been minimized.
|
Super! |
matklad
merged commit 41bf65f
into
intellij-rust:master
Feb 28, 2017
This comment has been minimized.
This comment has been minimized.
|
We might want to think about replacing colors with different icons (like in the build.rs case), to help colorblind people. And I'll take a look if we can easily move |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
And we might want to look at something like Though I'd prefer to stick with the current solution: it's less magic there. |
mkaput
deleted the
mkaput:icons
branch
Feb 28, 2017
mkaput
referenced this pull request
Feb 28, 2017
Closed
Use environment separators in custom file name provider #1043
This comment has been minimized.
This comment has been minimized.
|
Just want to say this is one of those features I didn't know I needed until it was added. Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.

mkaput commentedFeb 27, 2017
New icons for
build.rs,mod.rs&main.rs/lib.rs. I had no idea what symbol to choose for two former ones, so I opted for colouristic variants.I have removed svgs in favour of Illustrator files, because this format is easier to modify
fix #1038