Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more icons #1041

Merged
merged 1 commit into from Feb 28, 2017

Conversation

Projects
None yet
3 participants
@mkaput
Copy link
Member

mkaput commented Feb 27, 2017

New icons for build.rs, mod.rs & main.rs/lib.rs. I had no idea what symbol to choose for two former ones, so I opted for colouristic variants.

illustrator_2017-02-27_21-24-57
java_2017-02-27_21-24-23
java_2017-02-27_21-24-35

I have removed svgs in favour of Illustrator files, because this format is easier to modify

fix #1038

@matklad

This comment has been minimized.

Copy link
Member

matklad commented Feb 28, 2017

Super!

@matklad matklad merged commit 41bf65f into intellij-rust:master Feb 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matklad

This comment has been minimized.

Copy link
Member

matklad commented Feb 28, 2017

We might want to think about replacing colors with different icons (like in the build.rs case), to help colorblind people. And I'll take a look if we can easily move mod.rs to the top.

@matklad

This comment has been minimized.

Copy link
Member

matklad commented Feb 28, 2017

@matklad

This comment has been minimized.

Copy link
Member

matklad commented Feb 28, 2017

fire

@matklad

This comment has been minimized.

Copy link
Member

matklad commented Feb 28, 2017

And we might want to look at something like NestingTreeStructureProvider, to really display the module structure instead of file structure.

Though I'd prefer to stick with the current solution: it's less magic there.

@mkaput mkaput deleted the mkaput:icons branch Feb 28, 2017

@johnthagen

This comment has been minimized.

Copy link
Contributor

johnthagen commented Mar 6, 2017

Just want to say this is one of those features I didn't know I needed until it was added. Great job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.