Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCARGO: Don't explicitely set RUSTC env var #2078
Conversation
This comment has been minimized.
This comment has been minimized.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 27, 2017
This comment has been minimized.
This comment has been minimized.
Build failed |
matklad
force-pushed the
no-path
branch
from
737b745
to
9414904
Nov 27, 2017
This comment has been minimized.
This comment has been minimized.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 27, 2017
This comment has been minimized.
This comment has been minimized.
bors
bot
merged commit 9414904
into
master
Nov 27, 2017
2 checks passed
bors
Build succeeded
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
bors
bot
deleted the
no-path
branch
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
matklad commentedNov 27, 2017
It helps tools like clippy, which use their own RUSTC. Historically,
this was implemented because not everyone was using rustup, and, thus,
not everybody had
rustcin PATH, but hopefully this is not a problemanymore.
closes #1941