Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP (very wip) Index macro expansions #3015
+2,525
−394
Conversation
vlad20012
force-pushed the
vlad20012:macro-index
branch
3 times, most recently
from
458653d
to
28f2374
Nov 7, 2018
vlad20012
referenced this pull request
Nov 18, 2018
Merged
TY: Infer type of macros like cfg!() column!(), module_path!(), ... #3055
vlad20012
force-pushed the
vlad20012:macro-index
branch
from
28f2374
to
257a2fe
Nov 21, 2018
Undin
added
the
feature
label
Dec 30, 2018
vlad20012
added some commits
Sep 20, 2018
vlad20012
force-pushed the
vlad20012:macro-index
branch
from
257a2fe
to
f8cae63
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vlad20012 commentedNov 6, 2018
•
edited
Now most macros are expanded once (together with indexing) and stored persistently. This opens the way to index macro expansions, and thus support impls/modules declared with macros, and also make auto-import, find symbol/usages (and other index-driven features) to work with macros.
Also it should significantly increases performance.
Closes #2458.
Also fixes #2615, fixes #2902, fixes #2787, fixes #3006, fixes #2383, fixes #955, fixes #3087, fixes #3259, (... and more)
TODO: