INT: handle conversion of module to self in nest use intention #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
bors bot
added a commit
that referenced
this pull request
Mar 9, 2019
3501: INT: Make "unelide lifetimes" intention unavailable in doc comments r=vlad20012 a=vlad20012 It can be too annoying that this intention is available inside all doctest injections 3503: INT: handle conversion of module to self in nest use intention r=vlad20012 a=Kobzol This PR fixes an error in the `Nest use statements` intention mentioned here: #2577 (comment). Before the intention would change this code: ``` use foo; use foo::bar; ``` into ``` use foo::{foo, bar}`; ``` which is incorrect. Now it checks if the grouped path is the same as the base path and converts it to `self` if necessary. Co-authored-by: vlad20012 <beskvlad@gmail.com> Co-authored-by: Jakub Beránek <berykubik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error in the
Nest use statementsintention mentioned here: #2577 (comment).Before the intention would change this code:
into
which is incorrect.
Now it checks if the grouped path is the same as the base path and converts it to
selfif necessary.