TYPE: Fold Macro/MacroExpansion/Macro2 #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm working on test fixtures |
|
Done, it's now ready for review |
ice1000
changed the title
|
bors ping |
|
pong |
|
Rebased onto current master. |
|
bors ping |
|
pong |
Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
... and add my name to the contributor list by the way Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
|
Add comments addressed, CLA signed. Please take a look? |
|
Thanks! |
bors bot
added a commit
that referenced
this issue
Apr 25, 2019
3745: TYPE: Fold Macro/MacroExpansion/Macro2 r=mchernyavsky a=ice1000 Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> <!-- Hello and thank you for the pull request! We don't have any strict rules about pull requests, but you might check https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md for some hints! Note that we need an electronic CLA for contributions: https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md#cla After you sign the CLA, please add your name to https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTORS.txt :) --> Before folding:  After completely fold everything:  Only fold `MacroExpansion` blocks:  Before:  3758: CLEAN: fix typo r=vlad20012 a=vlad20012 bors r+ Co-authored-by: ice1000 <ice1000kotlin@foxmail.com> Co-authored-by: vlad20012 <beskvlad@gmail.com>
Timed out (retrying...) |
bors bot
added a commit
that referenced
this issue
Apr 25, 2019
3745: TYPE: Fold Macro/MacroExpansion/Macro2 r=mchernyavsky a=ice1000 Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> <!-- Hello and thank you for the pull request! We don't have any strict rules about pull requests, but you might check https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md for some hints! Note that we need an electronic CLA for contributions: https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md#cla After you sign the CLA, please add your name to https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTORS.txt :) --> Before folding:  After completely fold everything:  Only fold `MacroExpansion` blocks:  Before:  Co-authored-by: ice1000 <ice1000kotlin@foxmail.com>
|
bors retry |
|
Already running a review |
|
Maybe we should fix this warning? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Signed-off-by: ice1000 ice1000kotlin@foxmail.com
Before folding:
After completely fold everything:
Only fold
MacroExpansionblocks:Before:
