MACRO: disable name resolution for include with env("OUT_DIR") by default#4573
Merged
MACRO: disable name resolution for include with env("OUT_DIR") by default#4573
Conversation
Undin
changed the title
…ault Recently supported name resolution for included files uses `cargo build --build-plan` to fetch value of `OUT_DIR` environment variable (see #4542). Found out that `cargo build --build-plan` force next `build` command to recompile whole project (including dependencies). See rust-lang/cargo#5579 (comment). At this moment it is part of refresh, i.e. it is invoked on each `Cargo.toml` change, project reopening, etc. So this command is invoked quite frequently. It can be rather unexpected for large project to make full compilation after each project reopening So we decided to disable it by default until it will be fixed from cargo side or we'll find better way to get `OUT_DIR` value
Undin
force-pushed
the
undin/disable-out-dir-support
branch
from
dbc228f to
92b0554
Compare
Member
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 29, 2019
4573: MACRO: disable name resolution for include with env("OUT_DIR") by default r=Undin a=Undin
Recently supported name resolution for included files uses `cargo build --build-plan` to fetch value of `OUT_DIR` environment variable (see #4542).
Found out that `cargo build --build-plan` force next `build` command to recompile whole project (including dependencies).
See rust-lang/cargo#5579 (comment).
At this moment it is part of refresh, i.e. it is invoked on each `Cargo.toml` change, project reopening, etc. So this command is invoked quite frequently.
It can be rather unexpected for large project to make full compilation after each project reopening
So we decided to disable it by default until it will be fixed from cargo side or we'll find better way to get `OUT_DIR` value
Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
Contributor
3 tasks
|
For anyone wondering about how to access the experimental features dialog, it's briefly mentioned here: https://www.jetbrains.com/clion/features/run-and-debug.html It's accessed via the maintenance dialog which is summoned with ctrl+alt+shift+/ |
Member
Author
|
Also, you can find almost any IDE action, setting, etc. including |
Contributor
|
Or |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently supported name resolution for included files uses
cargo build --build-planto fetch value ofOUT_DIRenvironment variable (see #4542).Found out that
cargo build --build-planforces nextbuildcommand to recompile whole project (including dependencies).See rust-lang/cargo#5579 (comment).
At this moment it is part of refresh, i.e. it is invoked on each
Cargo.tomlchange, project reopening, etc. So this command is invoked quite frequently.It can be rather unexpected for large project to make full compilation after each project reopening
So we decided to disable it by default until it will be fixed from cargo side or we'll find a better way to get
OUT_DIRvalue. To turn it on just enableorg.rust.cargo.fetch.out.diroption inExperimental Featuresdialog