Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL: Fix macro completion inside Rust Console #4971

Merged
merged 1 commit into from Feb 19, 2020
Merged

REPL: Fix macro completion inside Rust Console #4971

merged 1 commit into from Feb 19, 2020

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Feb 16, 2020

Fix #4752

@Undin Undin added the fix Pull requests that fix some bug(s) label Feb 19, 2020
@Undin Undin added this to In Progress in To test via automation Feb 19, 2020
vlad20012
vlad20012 reviewed Feb 19, 2020
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

src/main/kotlin/org/rust/lang/core/psi/ext/PsiElement.kt
get() = contextOrSelf() ?: error("Element outside of file: $text")
get() {
val file = contextOrSelf<PsiFile>() ?: error("Element outside of file: $text")
return if (file is RsReplCodeFragment) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw looks like this should be applied to any types of code fragments

bors bot added a commit that referenced this pull request Feb 19, 2020
@bors @dima74
Merge #4971
4ef1ac8 
4971: REPL: Fix macro completion inside Rust Console r=vlad20012 a=dima74

Fix #4752

Co-authored-by: Dmitry Murzin <diralik@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Feb 19, 2020

Build succeeded

@bors bors bot merged commit 816edbd into intellij-rust:master Feb 19, 2020
To test automation moved this from In Progress to Test Feb 19, 2020
@Undin Undin added this to the v117 milestone Feb 20, 2020
@lancelote lancelote moved this from Test to Done in To test Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 left review comments

Assignees
No one assigned
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v117
Development

Successfully merging this pull request may close these issues.

No macro completion inside Rust Console
3 participants
@dima74 @vlad20012 @Undin