Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRD: improve developer workflows #5326

Merged
merged 3 commits into from May 5, 2020
Merged

GRD: improve developer workflows #5326

merged 3 commits into from May 5, 2020

Conversation

Undin
Copy link
Member

@Undin Undin commented May 4, 2020

These changes should speed up some developer workflows related to IDE launch:

  • platform version switch. Now we use different sandbox directories for different platform versions that should keep application data (like indices or expanded macros) when you change platform version. As a result, it eliminates unnecessary indexation when you want to check something with non-default platform version
  • debugging. Now gradle script debugging is disabled for RunIDEA and RunCLion run configurations that speeds up IDE launch

Other changes:

  • Run run configuration is renamed to RunIDEA to be consistent with RunCLion
  • configureCLion task is dropped as redundant because now we provide explicit sandbox name
  • CONTRIBUTING.md improvements and updates

@Undin Undin added this to the v122 milestone May 5, 2020
@Undin Undin added the internal Pull requests about internal improvements/fixes that don't affect users directly label May 5, 2020
@@ -1,6 +1,7 @@
<component name="ProjectRunConfigurationManager">
<configuration default="false" name="RunCLion" type="GradleRunConfiguration" factoryName="Gradle">
<log_file alias="idea.log" path="$PROJECT_DIR$/plugin/build/clion-sandbox/system/log/idea.log" />
<log_file alias="idea-201.log" path="$PROJECT_DIR$/plugin/build-201/clion-sandbox/system/log/idea.log" />
<log_file alias="idea-193.log" path="$PROJECT_DIR$/plugin/build-193/clion-sandbox/system/log/idea.log" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I don't know a way how to provide single path for all platform versions because run configurations support ant patterns only for filename

@Undin Undin force-pushed the undin/build-dirs branch 3 times, most recently from 0f78d95 to 6db7970 Compare May 5, 2020 14:51
@Undin Undin changed the title GRD: use different build dirs for different platform versions GRD: improve IDE launch via gradle May 5, 2020
@Undin Undin changed the title GRD: improve IDE launch via gradle GRD: improve developer workflows May 5, 2020
Undin added 3 commits May 5, 2020 19:07
It should speed up switching between different platform versions because we keep all application info (like indices) in separate directories and don't rewrite them while platform version switching

grd
…figurations

It should make IDE launch faster in debug mode
@vlad20012
Copy link
Member

👍
bors r+

@bors
Copy link
Contributor

bors bot commented May 5, 2020

@bors bors bot merged commit 2662227 into master May 5, 2020
@bors bors bot deleted the undin/build-dirs branch May 5, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Pull requests about internal improvements/fixes that don't affect users directly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants