INSP: add remove parameter quick fix to liveness inspection #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
insp-liveness-remove-parameter
branch
from
79b462f
to
14218c8
Compare
|
Rebased onto master with #5557. |
artemmukhin
approved these changes
Jun 19, 2020
src/main/kotlin/org/rust/ide/inspections/fixes/RemoveParameterFix.kt
Outdated
Show resolved
Hide resolved
Kobzol
force-pushed
the
insp-liveness-remove-parameter
branch
from
a1e16e7
to
7f8f3b2
Compare
|
I changed comma handling in such a way that only one comma is always removed, either the preceding or the following, based on which one is present. This handles parameter removal at the beginning, middle and end of parameter lists, and it also keeps trailing commas. foo(p0, /*caret*/p1) -> foo(p0)
foo(p0, /*caret*/p1, ) -> foo(p0, ) |
artemmukhin
approved these changes
Jun 22, 2020
|
bors r=ortem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a quick fix to remove an unused parameter, along with its usages in call sites. The call site arguments are removed without any checks for side effects, same as in the Kotlin plugin.
Should we ignore call sites with an incorrect number of arguments?
This PR is based on #5557 which introduced some common changes. I opened this one for discussion, but #5557 should be merged first, I'll rebase this one after/if it gets merged.
Part of #3163