T: add test that intentions have descriptions and templates #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
added
the
internal
Undin
reviewed
Sep 2, 2020
Kobzol
force-pushed
the
t-intention-description
branch
from
6abdbfb
to
2dd08e0
Compare
bors bot
added a commit
that referenced
this pull request
Sep 3, 2020
6042: T: add test that intentions have descriptions and templates r=Undin a=Kobzol This PR adds a test to all intentions that they have proper description and templates (inspired by a similar test in inspection test base class). Blocked on #6050 Co-authored-by: Jakub Beránek <berykubik@gmail.com>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2020
6042: T: add test that intentions have descriptions and templates r=Undin a=Kobzol This PR adds a test to all intentions that they have proper description and templates (inspired by a similar test in inspection test base class). Blocked on #6050 Co-authored-by: Jakub Beránek <berykubik@gmail.com>
|
Build failed:
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2020
6042: T: add test that intentions have descriptions and templates r=Undin a=Kobzol This PR adds a test to all intentions that they have proper description and templates (inspired by a similar test in inspection test base class). Blocked on #6050 Co-authored-by: Jakub Beránek <berykubik@gmail.com>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2020
6042: T: add test that intentions have descriptions and templates r=Undin a=Kobzol This PR adds a test to all intentions that they have proper description and templates (inspired by a similar test in inspection test base class). Blocked on #6050 Co-authored-by: Jakub Beránek <berykubik@gmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2020
6042: T: add test that intentions have descriptions and templates r=Undin a=Kobzol This PR adds a test to all intentions that they have proper description and templates (inspired by a similar test in inspection test base class). Blocked on #6050 Co-authored-by: Jakub Beránek <berykubik@gmail.com>
|
Build failed:
|
|
@Undin is it possible to see why the merge failed? I can't see it on GitHub nor in BORS. |
|
@Kobzol Yep. |
|
bors r+ |
|
Build succeeded: |
|
Oh, I knew that, but somehow I missed the red cross marks 🤦♂️ Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to all intentions that they have proper description and templates (inspired by a similar test in inspection test base class).
Blocked on #6050