COMP: simplify script for fetching Clippy lints #6305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
added
the
internal
Undin
reviewed
Oct 28, 2020
Kobzol
force-pushed
the
comp-fetch-clippy
branch
from
fffc0be
to
df3705e
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in the Rust Analyzer changelog that they also added lint completion a few days ago (what a coincidence! :D ). They use a JSON with all Clippy lints that I didn't know of. It's a much simpler solution than cloning the
clippyrepository, which is what I have done in the original PR.Theoretically, the Python script could now be moved back into
build.gradle.kts, but I don't think it's worth it.