ANN: Add quick fix to correct invalid cfg predicates #7165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
changed the title
Kobzol
force-pushed
the
ann-unknown-cfg-predicate-fix
branch
from
9cc7271
to
c5e7ed5
Compare
Undin
reviewed
Apr 28, 2021
src/main/kotlin/org/rust/ide/annotator/fixes/NameSuggestionFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/annotator/fixes/NameSuggestionFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/annotator/fixes/NameSuggestionFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/annotator/fixes/NameSuggestionFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/annotator/fixes/NameSuggestionFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/annotator/fixes/NameSuggestionFix.kt
Outdated
Show resolved
Hide resolved
Kobzol
force-pushed
the
ann-unknown-cfg-predicate-fix
branch
2 times, most recently
from
588fb1b
to
f6cc7a2
Compare
|
Rebased & fixed comments. |
Undin
approved these changes
Apr 28, 2021
src/main/kotlin/org/rust/ide/annotator/fixes/NameSuggestionFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/annotator/fixes/NameSuggestionFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/annotator/fixes/NameSuggestionFix.kt
Outdated
Show resolved
Hide resolved
|
And could you add |
Kobzol
force-pushed
the
ann-unknown-cfg-predicate-fix
branch
from
f6cc7a2
to
f78a5e7
Compare
|
bors r=Undin |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #7102 by adding a quick fix to correct invalid cfg name.
Note that I couldn't just use
RenameFix, because this fix has to work onRsPathin the case ofcfgpredicates. And in this way the fix is general and it can be used in more places.changelog: Add quick fix to correct the name of an invalid cfg predicate.