Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARGO: fix build script evaluation in workspace #8056

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

Undin
Copy link
Member

@Undin Undin commented Nov 3, 2021

Previously, if root Cargo.toml defined both package and workspace, the plugin compiled only package. As a result, the plugin knew nothing about items generated in other workspace packages.

Now, we pass --workspace flag to compile all packages in workspace and get info about generated items in all packages

Should fix #5878

changelog: Fix build script evaluation in workspace. Note, build script evaluation is disabled by default. To turn it on, enable org.rust.cargo.evaluate.build.scripts experimental feature

Previously, if root `Cargo.toml` defined both package and workspace, the plugin compiled only package. As a result, the plugin knew nothing about items generated in other workspace packages.

Now, we pass `--workflow` flag to compile all packages in workspace and get info about generated items in all packages
@Undin Undin added the fix Pull requests that fix some bug(s) label Nov 3, 2021
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 5, 2021

Build succeeded:

@bors bors bot merged commit a917140 into master Nov 5, 2021
@bors bors bot deleted the undin/build-script-in-workspace branch November 5, 2021 17:17
@github-actions github-actions bot added this to the v160 milestone Nov 5, 2021
@mili-l mili-l self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include! OUT_DIR completion broken in workspaces
3 participants