Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept new constructor() syntax #68

Closed
rossng opened this issue Apr 14, 2018 · 5 comments
Closed

Accept new constructor() syntax #68

rossng opened this issue Apr 14, 2018 · 5 comments

Comments

@rossng
Copy link

@rossng rossng commented Apr 14, 2018

The nightly versions of the Solidity compiler now use the constructor(args) instead of function ContractName(args) syntax. I tried to add this in intellij-solidity myself but I don't have enough time to get my head around how the parser generators work.

@SerCeMan
Copy link
Member

@SerCeMan SerCeMan commented Apr 16, 2018

I believe that this can be fixed by updating the grammar, some instructions can be found here: #13 (comment). I tried to find some docs on this, but it seems that even grammar.txt in the solidity repo is not updated yet.

@rossng
Copy link
Author

@rossng rossng commented Apr 17, 2018

I may not have a chance to do this for a while (there's a thesis that needs written!), but it looks like the syntax is now in the official 0.4.22 release of Solidity.

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Apr 18, 2018

Let me do this.

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Apr 18, 2018

Created a pull request that supports this syntax, but related completions are not included, awaiting further development.

@ice1000
Copy link
Contributor

@ice1000 ice1000 commented Apr 19, 2018

@SerCeMan Close this plz 😜

@SerCeMan SerCeMan closed this Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants