New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "constructor" syntax #69
Conversation
Why doesn't this compile? I don't think changing to 2018.1 will cause the strange compilation error shown in the CI log. I can compile it and run tests on my laptop. |
All failed tests are under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I'll take one and will merge it today 👍
if (ijEvent == null) { | ||
return true | ||
} | ||
val ijEvent = events.firstOrNull() ?: return true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally try to avoid nullable ?: return smth
idiom because it often hides the control flow in debugging, e.g. it's often unclear at which moment the method gets returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, reverted.
Oh, just noticed messages about the errors, I'll try to check why |
The generated AST has probably changed |
Have you mentioned my change in the |
I haven't tried to run these tests locally yet, but you can try to regenerate lexer/parser (there is a run configuration for this), and run the test locally to see the difference. If there is no difference then I can't say off the top of my head what's wrong, but I'll take a look. |
@SerCeMan Fixed test cases. It's actually the difference of the error message. |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
============================================
- Coverage 47.82% 47.77% -0.06%
Complexity 116 116
============================================
Files 78 78
Lines 2022 2018 -4
Branches 366 363 -3
============================================
- Hits 967 964 -3
- Misses 933 935 +2
+ Partials 122 119 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
When are you planning to make a release with this PR? |
Hey, @Kipriz! Probably this week, there are some issues/features that require additional testing, in the meantime, you can build a version from master using the instructions in README |
According to #68