Support "constructor" syntax #69
Conversation
Why doesn't this compile? I don't think changing to 2018.1 will cause the strange compilation error shown in the CI log. I can compile it and run tests on my laptop. |
All failed tests are under |
Thanks for this. I'll take one and will merge it today |
if (ijEvent == null) { | ||
return true | ||
} | ||
val ijEvent = events.firstOrNull() ?: return true |
SerCeMan
Apr 19, 2018
Member
I intentionally try to avoid nullable ?: return smth
idiom because it often hides the control flow in debugging, e.g. it's often unclear at which moment the method gets returned.
I intentionally try to avoid nullable ?: return smth
idiom because it often hides the control flow in debugging, e.g. it's often unclear at which moment the method gets returned.
ice1000
Apr 19, 2018
Author
Contributor
Ok, reverted.
Ok, reverted.
Oh, just noticed messages about the errors, I'll try to check why |
The generated AST has probably changed |
Have you mentioned my change in the |
I haven't tried to run these tests locally yet, but you can try to regenerate lexer/parser (there is a run configuration for this), and run the test locally to see the difference. If there is no difference then I can't say off the top of my head what's wrong, but I'll take a look. |
@SerCeMan Fixed test cases. It's actually the difference of the error message. |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
============================================
- Coverage 47.82% 47.77% -0.06%
Complexity 116 116
============================================
Files 78 78
Lines 2022 2018 -4
Branches 366 363 -3
============================================
- Hits 967 964 -3
- Misses 933 935 +2
+ Partials 122 119 -3
Continue to review full report at Codecov.
|
Looks great to me! |
19f1a25
into
intellij-solidity:master
When are you planning to make a release with this PR? |
Hey, @Kipriz! Probably this week, there are some issues/features that require additional testing, in the meantime, you can build a version from master using the instructions in README |
According to #68