Skip to content

Conversation

@LordOfPolls
Copy link
Contributor

About

Resolves issues where tasks will execute if you dont start them instantly. This also resolves the similar issue that occurs if you stop tasks and then start them again later.

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.
  • I have added the versionadded, versionchanged and deprecated to any new or changed user-facing function I committed.

Pull-Request specification

I've made this pull request: (check all that apply)

This is:

  • A breaking change

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.01 ⚠️

Comparison is base (a6d8e22) 47.72% compared to head (371149c) 47.72%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##              5.x    #1326      +/-   ##
==========================================
- Coverage   47.72%   47.72%   -0.01%     
==========================================
  Files         139      139              
  Lines       14282    14285       +3     
==========================================
+ Hits         6816     6817       +1     
- Misses       7466     7468       +2     
Impacted Files Coverage Δ
interactions/models/internal/tasks/task.py 41.57% <0.00%> (-0.48%) ⬇️
interactions/models/internal/tasks/triggers.py 44.64% <50.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LordOfPolls LordOfPolls linked an issue Apr 7, 2023 that may be closed by this pull request
1 task
@LordOfPolls
Copy link
Contributor Author

@Toricane please see above

Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LordOfPolls LordOfPolls merged commit d6adfd0 into 5.x Apr 7, 2023
@LordOfPolls LordOfPolls deleted the task-fix branch April 7, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] inconsistencies and bugs in tasks

4 participants