Skip to content

Conversation

@AstreaTSS
Copy link
Member

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Seems like people forgot ephemeral exists for hybrid commands while testing... though it is a weird decision to use one there. Regardless, this PR fixes a bug that prevented it from working for slash command usages.

Changes

  • Properly check if _slash_ctx exist when doing ephemeral checks.

Related Issues

Test Scenarios

  • Make hybrid command with an ephemeral message.
  • Use the slash command version.

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@LordOfPolls LordOfPolls merged commit de24263 into interactions-py:unstable Jul 5, 2023
@AstreaTSS AstreaTSS deleted the hybrid-ephemeral-fix branch July 13, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants