Skip to content

Conversation

@anand2312
Copy link
Contributor

@anand2312 anand2312 commented May 3, 2021

About this pull request

Updates docstring in SlashContext.send to remove an outdated note, regarding embeds in ephemeral messages.
Closes #167

Checklist

  • I've checked this pull request runs on Python 3.6.X.
  • This fixes something in Issues.
    • Issue:
  • This adds something new.
  • There is/are breaking change(s).
  • (If required) Relevant documentation has been updated/added.
  • This is not a code change. (README, docs, etc.)

@quirky-bluejay
Copy link
Contributor

The warning on send should also be removed

@anand2312
Copy link
Contributor Author

The warning on send should also be removed

preview This?

@quirky-bluejay
Copy link
Contributor

I meant the code logger warming, but that too. And yeah that bit of code for sending files should be changed, if files are now supported.

@anand2312
Copy link
Contributor Author

I meant the code logger warming, but that too. And yeah that bit of code for sending files should be changed, if files are now supported.

I don't know if they are? I made this PR only because of a discussion I saw in the server, and am not familiar with this codebase
If you want me to make some more changes, can you point exactly which files / what needs to be done?

@quirky-bluejay
Copy link
Contributor

If you'd like me to make those changes I'm happy to open another pr!

@eunwoo1104
Copy link
Contributor

Merging, thank you for contributing!

@eunwoo1104 eunwoo1104 merged commit 8172477 into interactions-py:master May 12, 2021
@anand2312 anand2312 deleted the patch-1 branch May 15, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ephemeral (hidden) Messages now support embeds

4 participants