Futher improvements in components implementation #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4e2c310)
(cherry picked from commit f4e34ff)
…nent (cherry picked from commit 06f3437)
(cherry picked from commit 296792f)
(cherry picked from commit 1d33e7f)
(cherry picked from commit 3eb8c27)
(cherry picked from commit 9e242ef)
(cherry picked from commit 0ecd922)
(cherry picked from commit a664f4a)
(cherry picked from commit 3a6dee2)
LordOfPolls
approved these changes
Jun 8, 2021
i0bs
reviewed
Jun 8, 2021
i0bs
reviewed
Jun 8, 2021
i0bs
reviewed
Jun 8, 2021
i0bs
suggested changes
Jun 8, 2021
Contributor
i0bs
left a comment
i0bs
left a comment
There was a problem hiding this comment.
Some minor changes requested.
Contributor
Author
|
Thank you very much for your feedback, I applied requested changes |
i0bs
approved these changes
Jun 11, 2021
LordOfPolls
approved these changes
Jun 11, 2021
artem30801
added a commit
to artem30801/discord-py-interactions
that referenced
this pull request
Jun 13, 2021
LordOfPolls
pushed a commit
that referenced
this pull request
Jun 18, 2021
* Add support for component callbacks * Refactored component callbacks. Added cog callbacks support * Added component_callback event dispatching, removed testing prints * Added error handling event for component callbacks (same as for slash commands) * Applied pre_push * Fix for when remove_component_callback is used before remove_component_callback_obj * Update docs for changes * Added ability to dynamically modify component callbacks * Updated docs and formatting * Updated formatting * Updated in accordance to breaking changes introduced in #204 * Fix sphinx errors * Changed component adding functions to accept lists (and objects) of custom_ids/message ids in the same arguments * Added function to spread list of components (buttons) over rows * Adjusted docstrings and error message Co-authored-by: hpenney2 <hpenney1010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this pull request
Futher improvements in components implementation
Cherry-picked commits from previous draft to improve commit log
Changes
What changes were made?
Checklist
Python 3.6.X.