-
Notifications
You must be signed in to change notification settings - Fork 187
Components callbacks #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LordOfPolls
merged 18 commits into
interactions-py:components
from
artem30801:artem30801-cog-comp-callbacks
Jun 18, 2021
Merged
Components callbacks #210
LordOfPolls
merged 18 commits into
interactions-py:components
from
artem30801:artem30801-cog-comp-callbacks
Jun 18, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem30801/discord-py-slash-command into artem30801-cog-comp-callbacks
LordOfPolls
reviewed
Jun 14, 2021
…ustom_ids/message ids in the same arguments
LordOfPolls
approved these changes
Jun 17, 2021
Contributor
LilSpazJoekp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions.
i0bs
approved these changes
Jun 18, 2021
Contributor
i0bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this pull request
Added support of component callbacks!
Rewiews on naming of functions, classes and arguments will be very appreciated, as some of the current method names feel too long or ambigous.
Changes
CommandObjectto newCallbackObjectbase classComponentCallbackObjectandCogComponentCallbackObjectto hold component callback data (inherits fromCallbackObject)SlashCommandto add, remove and manage component callbacksadd_component_callbackto registeer function as component callbackcustom_iddefaults to function name in not specifiedextend_component_callbackto dynamically add combination of message_id and custom_id to existing callback objectget_component_callbackto get component callback by message_id, custom_id, component_typeremove_component_callbackto dynamically remove combination of message_id and custom_id from listening for callbacksremove_component_callback_objto remove all listeners (combinations of message_id and custom_id) assosiated with specified callback objectcomponent_callbackdecorator toSlashCommandto register function as component callbackcog_componentdecorator tocog_extto register cog method as component callbackon_component_callbackevent triggered along with actual component callbackon_component_callback_errorto work in same manner as slash commands do nowChecklist
Python 3.6.X.