Skip to content

Remove positional arg support #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2021
Merged

Remove positional arg support #214

merged 2 commits into from
Jun 18, 2021

Conversation

@LordOfPolls
Copy link
Contributor

@LordOfPolls LordOfPolls commented Jun 18, 2021

About this pull request

Removes positional arg support as per vote

Changes

  • Removed positional arg support
  • Added migration documentation

Checklist

  • I've checked this pull request runs on Python 3.6.X.
  • This fixes something in Issues.
    • Issue:
  • This adds something new.
  • There is/are breaking change(s).
  • (If required) Relevant documentation has been updated/added.
  • This is not a code change. (README, docs, etc.)

@i0bs i0bs self-requested a review June 18, 2021 20:29
i0bs
i0bs approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@i0bs i0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nyooom

@LordOfPolls
Copy link
Contributor Author

LordOfPolls commented Jun 18, 2021

nyooom has declared this code safe to merge.

hippity hoppity this code is now my property

@LordOfPolls LordOfPolls merged commit 6e0d077 into interactions-py:components Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@i0bs i0bs i0bs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LordOfPolls @i0bs