Skip to content

refactor: Allow components during an edit; safeguard from missing HTTPClient. #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 20, 2022
Merged

refactor: Allow components during an edit; safeguard from missing HTTPClient. #433

merged 12 commits into from
Jan 20, 2022

Conversation

@EepyElvyra
Copy link
Contributor

@EepyElvyra EepyElvyra commented Jan 14, 2022 •
edited
Loading

About

This PR is about:

refactor:

  • raise an error if HTTPClient is not defined in helper methods to have a clearer error
  • add explanation of that error and fix to faq
  • allow components in replies and edits of messages

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EepyElvyra
refactor:
d62dfb2 
- raise error if HTTPClient is not defined in helper methods to have a clearer error
- add explanation of that error and fix to faq
- began channel.purge
@EepyElvyra
thing
2285847
@FayeDel
Copy link
Collaborator

FayeDel commented Jan 15, 2022

I cba to comment this at every instance, but there's a typo at every instance of raise AttributeError("HTTTPClient not found!"), please adjust.

@EepyElvyra
Copy link
Contributor Author

EepyElvyra commented Jan 16, 2022

I cba to comment this at every instance, but there's a typo at every instance of raise AttributeError("HTTTPClient not found!"), please adjust.

Should be fixed now

@i0bs i0bs changed the title refactor: allow components in message edit and reply and set an error if the HTTPClient is not present in the helper methods refactor: Allow components during an edit; safeguard from missing HTTPClient. Jan 20, 2022
@i0bs i0bs merged commit 368fd5a into interactions-py:unstable Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@i0bs i0bs i0bs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EepyElvyra @FayeDel @i0bs