refactor: reorganize http endpoints #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EepyElvyra
changed the title
EepyElvyra
changed the title
EepyElvyra
added
breaking
Contributor
|
this is the most unprofessional comment i can make but holy shit thank god we're finally doing this i've absolutely hated the original way we've been doing it thus far |
Contributor
Author
lets get this on starboard then |
i0bs
suggested changes
Mar 13, 2022
Co-authored-by: fl0w <41456914+goverfl0w@users.noreply.github.com>
Contributor
Author
|
All checks passed now |
i0bs
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR corrects HTTPClient typehints and also adds a pyi
Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.