feat: add __eq__ to Snowflake
#641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i0bs
suggested changes
Mar 13, 2022
Contributor
i0bs
left a comment
i0bs
left a comment
There was a problem hiding this comment.
remove outdated comments. our choice on the existence of snowflake comparison seems pretty clear on how we use the paradigm in parallel to conditions.
auto-merge was automatically disabled
March 13, 2022 23:39
Head branch was pushed to by a user without write access
i0bs
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request adds the
__eq__magic method to the Snowflake modelChecklist
pre-committo format and lint the change(s) made.3.8.6and higher.