Skip to content

fix: Fix client presence Unix time calculation. #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 1, 2022
Merged

fix: Fix client presence Unix time calculation. #763

merged 5 commits into from
May 1, 2022

Conversation

@FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Apr 28, 2022

About

This pull request fixes changing statuses on runtime.
Before this PR, the main feasible way to do so bugs out when the status in question isn't idle.

Do note that there's an odd bug (on testing) that deals with invisible statuses that I can't seem to figure out yet.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@FayeDel FayeDel added bug Something isn't working priority This Issue/PR must be resolved first before accepting any others labels Apr 28, 2022
EepyElvyra
EepyElvyra approved these changes Apr 30, 2022
View reviewed changes
Copy link
Contributor

@EepyElvyra EepyElvyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FayeDel FayeDel merged commit 1954a04 into interactions-py:unstable May 1, 2022
@FayeDel FayeDel deleted the unstable_gateway_2 branch May 16, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EepyElvyra EepyElvyra EepyElvyra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working priority This Issue/PR must be resolved first before accepting any others

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FayeDel @EepyElvyra