Skip to content

fix: Allow sub command autocomplete dispatch #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2022
Merged

fix: Allow sub command autocomplete dispatch #781

merged 2 commits into from
May 11, 2022

Conversation

@EepyElvyra
Copy link
Contributor

@EepyElvyra EepyElvyra commented May 8, 2022

About

This pull request corrects the autocomplete dispatch so it works for subcommands

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EepyElvyra EepyElvyra added the bug Something isn't working label May 8, 2022
@EepyElvyra EepyElvyra requested review from AstreaTSS and removed request for Catalyst4222 May 8, 2022 12:02
@AstreaTSS AstreaTSS added the priority This Issue/PR must be resolved first before accepting any others label May 9, 2022
@EepyElvyra EepyElvyra enabled auto-merge (squash) May 9, 2022 19:53
Toricane
Toricane reviewed May 11, 2022
View reviewed changes
Toricane
Toricane approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EepyElvyra EepyElvyra merged commit 570c671 into interactions-py:unstable May 11, 2022
@EepyElvyra EepyElvyra deleted the Autocomplete branch May 11, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FayeDel FayeDel Awaiting requested review from FayeDel

@AstreaTSS AstreaTSS Awaiting requested review from AstreaTSS

1 more reviewer

@Toricane Toricane Toricane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working priority This Issue/PR must be resolved first before accepting any others

Projects

core
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EepyElvyra @Toricane @AstreaTSS