From 133161f8febf5481c65c870e1dd32f8a4cd517c2 Mon Sep 17 00:00:00 2001 From: Damego Date: Thu, 21 Jul 2022 19:45:29 +0500 Subject: [PATCH 1/3] refactor: add missed logic to ``Embed.insert_field_at`` --- interactions/api/models/message.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/interactions/api/models/message.py b/interactions/api/models/message.py index a682a9fb6..2cf1f69a5 100644 --- a/interactions/api/models/message.py +++ b/interactions/api/models/message.py @@ -578,6 +578,17 @@ def insert_field_at( :type inline?: Optional[bool] """ + try: + fields = self.fields + fields.insert(index, EmbedField(name=name, value=value, inline=inline)) + self.fields = fields + + except AttributeError as e: + raise AttributeError("No fields found in Embed") from e + + except IndexError as e: + raise IndexError("No fields at this index") from e + def set_field_at( self, index: int, name: str, value: str, inline: Optional[bool] = False ) -> None: From c71f045d6a465770ac02369c26dac4945e9e6882 Mon Sep 17 00:00:00 2001 From: Damego Date: Thu, 21 Jul 2022 19:56:16 +0500 Subject: [PATCH 2/3] make name and value required --- interactions/api/models/message.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interactions/api/models/message.py b/interactions/api/models/message.py index 2cf1f69a5..d8494143b 100644 --- a/interactions/api/models/message.py +++ b/interactions/api/models/message.py @@ -563,7 +563,7 @@ def clear_fields(self) -> None: self.fields = [] def insert_field_at( - self, index: int, name: str = None, value: str = None, inline: Optional[bool] = False + self, index: int, name: str, value: str, inline: Optional[bool] = False ) -> None: """ Inserts a field in the embed at the specified index From 9d611f1befbd9075ee0a52872e4d9f0487cb432a Mon Sep 17 00:00:00 2001 From: Damego Date: Thu, 21 Jul 2022 20:03:37 +0500 Subject: [PATCH 3/3] remove excepting indexerror --- interactions/api/models/message.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/interactions/api/models/message.py b/interactions/api/models/message.py index d8494143b..73f5fa693 100644 --- a/interactions/api/models/message.py +++ b/interactions/api/models/message.py @@ -586,9 +586,6 @@ def insert_field_at( except AttributeError as e: raise AttributeError("No fields found in Embed") from e - except IndexError as e: - raise IndexError("No fields at this index") from e - def set_field_at( self, index: int, name: str, value: str, inline: Optional[bool] = False ) -> None: