Skip to content

Conversation

@Damego
Copy link
Member

@Damego Damego commented Jul 31, 2022

About

This pull request adds __str__ magic method to Emoji.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue (If existent):.
    • resolves #
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@Damego Damego changed the title feat: add __str__ to Emoji feat!: add __str__ to Emoji Jul 31, 2022
@Damego
Copy link
Member Author

Damego commented Aug 2, 2022

I have another idea.
What if instead of magic method use @property?

@property
def str(self): # or `as_str/to_str`
  ...

@EepyElvyra
Copy link
Contributor

I have another idea.
What if instead of magic method use @property?

@property
def str(self): # or `as_str/to_str`
  ...

That won't be called automatically so I don't think that's good

@Damego
Copy link
Member Author

Damego commented Aug 2, 2022

I have another idea.
What if instead of magic method use @property?

@property
def str(self): # or `as_str/to_str`
  ...

That won't be called automatically so I don't think that's good

But we will see string format of emoji in print. Its not good too

@EepyElvyra
Copy link
Contributor

I have another idea.
What if instead of magic method use @property?

@property
def str(self): # or `as_str/to_str`
  ...

That won't be called automatically so I don't think that's good

But we will see string format of emoji in print. Its not good too

Imho it should be like that on print

@Damego
Copy link
Member Author

Damego commented Aug 2, 2022

okay lol

@EepyElvyra EepyElvyra merged commit 13d024a into interactions-py:unstable Aug 3, 2022
EepyElvyra added a commit that referenced this pull request Aug 10, 2022
* Update base.py

* refactor: change condition for getting error message (#973)

* refactor: change condition for getting error message

* ci: correct from checks.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* revert!: revert removed fixes for attrs (#974)

* return back fix

* return back Delta fix

* make check like Delta

* Update attrs_utils.py

* Update client.py (#975)

* refactor: move ``Emoji`` to own module (#978)

* refactor: separate Emoji to own module

* fix imports

* rename imports in http

* change brackets

* ci: pre-commit

* fix: fix incorrect role converts in Emoji

* ref: remove Role import

* fix: added default None value to optional args (#982)

* fix: fix error ``Attachment`` is not JSON serializable (#983)

* fix: fix error ``Attachment`` is not JSON serializable

* Update interactions/api/models/message.py

Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>

* chore: Version bump (#984)

* feat!: Add converters to components (#981)

* refactor!: Add converters to components

* ci: run pre-commit

* doc: add missed docstring

* oop

* fix: fix option type parsing in option decorator (#986)

* fix: fix error with converting components in edit (#987)

* fix: fix error with converting components in edit

* add build components to message.edit

* doc

* Revert "doc"

This reverts commit a9eda7b.

* feat: Add support for message_delete_bulk event (#990)

* feat: add support for messa_delete_bulk event

* fix: add missing comma

* ci: weekly check. (#991)

updates:
- [github.com/PyCQA/flake8: 4.0.1 → 5.0.2](PyCQA/flake8@4.0.1...5.0.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: add ``__str__`` to ``Emoji`` (#988)

* fix: remove bug with converting empty list to actionrow (#997)

* fix: fix converting empty list to actionrow

* move check

* ci: correct from checks.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix: wrong sequence in getting channel overwrites (#998)

* fix: fix few bugs with reactions (#993)

* chore: bump version to 4.3.1

* fix: add search_iterable() to __all__ (#1003)

* fix: Remove empty _client attribute in _json property (#999)

* fix: Remove empty _client attribute in _json property

* refactor: conditional logic

* fix: add member's _client for message reactions (#994)

* fix: add member's _client for message reactions

* refactor: change to add_client

Yes I did not know that it exists sorry

* ci: weekly check. (#1009)

updates:
- [github.com/PyCQA/flake8: 5.0.2 → 5.0.4](PyCQA/flake8@5.0.2...5.0.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor: change condition in update dispatch (#1004)

* docs: fix incorrect codeblocks (#1006)

* docs: fix incorrect codeblocks

* Update interactions/client/models/component.py

Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>

Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>

* feat: Add member and channel permissions calculation functions (#969)

* feat: added member and channel permissions functions

* ci: correct from checks.

* docs: update docs

* refactor: switch from ALL_PERMISSIONS to Permissions.ALL & DEFAULT

* feat: add default permissions if in DM

* fix: small fixes

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
Co-authored-by: Damego <danyabatueff@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: DeltaX <33706469+DeltaXWizard@users.noreply.github.com>
Co-authored-by: Damego <damego.dev@gmail.com>
@Damego Damego deleted the feat-add-str-to-emoji branch December 6, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants