-
Notifications
You must be signed in to change notification settings - Fork 187
feat!: add __str__ to Emoji
#988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add __str__ to Emoji
#988
Conversation
|
I have another idea. @property
def str(self): # or `as_str/to_str`
... |
That won't be called automatically so I don't think that's good |
But we will see string format of emoji in |
Imho it should be like that on print |
|
okay lol |
* Update base.py * refactor: change condition for getting error message (#973) * refactor: change condition for getting error message * ci: correct from checks. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * revert!: revert removed fixes for attrs (#974) * return back fix * return back Delta fix * make check like Delta * Update attrs_utils.py * Update client.py (#975) * refactor: move ``Emoji`` to own module (#978) * refactor: separate Emoji to own module * fix imports * rename imports in http * change brackets * ci: pre-commit * fix: fix incorrect role converts in Emoji * ref: remove Role import * fix: added default None value to optional args (#982) * fix: fix error ``Attachment`` is not JSON serializable (#983) * fix: fix error ``Attachment`` is not JSON serializable * Update interactions/api/models/message.py Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com> * chore: Version bump (#984) * feat!: Add converters to components (#981) * refactor!: Add converters to components * ci: run pre-commit * doc: add missed docstring * oop * fix: fix option type parsing in option decorator (#986) * fix: fix error with converting components in edit (#987) * fix: fix error with converting components in edit * add build components to message.edit * doc * Revert "doc" This reverts commit a9eda7b. * feat: Add support for message_delete_bulk event (#990) * feat: add support for messa_delete_bulk event * fix: add missing comma * ci: weekly check. (#991) updates: - [github.com/PyCQA/flake8: 4.0.1 → 5.0.2](PyCQA/flake8@4.0.1...5.0.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat: add ``__str__`` to ``Emoji`` (#988) * fix: remove bug with converting empty list to actionrow (#997) * fix: fix converting empty list to actionrow * move check * ci: correct from checks. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix: wrong sequence in getting channel overwrites (#998) * fix: fix few bugs with reactions (#993) * chore: bump version to 4.3.1 * fix: add search_iterable() to __all__ (#1003) * fix: Remove empty _client attribute in _json property (#999) * fix: Remove empty _client attribute in _json property * refactor: conditional logic * fix: add member's _client for message reactions (#994) * fix: add member's _client for message reactions * refactor: change to add_client Yes I did not know that it exists sorry * ci: weekly check. (#1009) updates: - [github.com/PyCQA/flake8: 5.0.2 → 5.0.4](PyCQA/flake8@5.0.2...5.0.4) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor: change condition in update dispatch (#1004) * docs: fix incorrect codeblocks (#1006) * docs: fix incorrect codeblocks * Update interactions/client/models/component.py Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com> Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com> * feat: Add member and channel permissions calculation functions (#969) * feat: added member and channel permissions functions * ci: correct from checks. * docs: update docs * refactor: switch from ALL_PERMISSIONS to Permissions.ALL & DEFAULT * feat: add default permissions if in DM * fix: small fixes Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com> Co-authored-by: Damego <danyabatueff@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: DeltaX <33706469+DeltaXWizard@users.noreply.github.com> Co-authored-by: Damego <damego.dev@gmail.com>
About
This pull request adds
__str__magic method toEmoji.Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.