Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure rubocop #231

Merged
merged 9 commits into from Aug 9, 2019

Conversation

@yhirano55
Copy link
Member

commented Aug 8, 2019

We have to keep our codes clean minimally. So Enabled rubocop in committee gem.

Summary

  • Add rubocop, rubocop-performance to dev dependencies.
  • But its configuration is DisabledByDefault: false.
  • Run rubocop task with default rake task.
  • Enable Style/HashSyntax (avoid 馃殌 hash)
  • Enable Style/FrozenStringLiteralComment (for performance)
  • Enable Performance/RedundantMerge cop (for performance)
  • Enable Performance/UnfreezeString cop (for performance)

@yhirano55 yhirano55 force-pushed the configure_rubocop branch from 337fcf1 to 14f4352 Aug 9, 2019

@yhirano55 yhirano55 changed the title [WIP] Configure rubocop Configure rubocop Aug 9, 2019

@yhirano55 yhirano55 requested a review from ota42y Aug 9, 2019

@ota42y

ota42y approved these changes Aug 9, 2019

@ota42y ota42y merged commit 9d429df into master Aug 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ota42y ota42y deleted the configure_rubocop branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.