Move details tags #333
Merged
Move details tags #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geemus
requested changes
Dec 7, 2017
| @@ -37,6 +38,8 @@ Stability: `<%= schemata['stability'] %>` | |||
| | **<%= name %>** | *<%= type %>* | <%= description %> | <%= example %> | | |||
| <%- end %> | |||
|
|
|||
| </details> | |||
|
|
|||
| <%- end %> | |||
| <%- (schemata['links'] || []).each do |link, datum| %> | |||
There was a problem hiding this comment.
From your example, I think there would need to be another details block here also? Is that what you intended?
There was a problem hiding this comment.
Links means that each link has own details. So, our code creates documents like this.
- Attributes (don't show when there are no properties)
- Details >
- Link1 (this has anchor for toc link)
- Details >
- Link2 (also this has.)
- Details >
Currently, Here is link details tag.
There was a problem hiding this comment.
Ah, right you are, thanks for clarifying for me.
geemus
approved these changes
Dec 8, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the PR (#330), we need opening details to use table of contents links now.
I guess here is a better position.
I changed
From,
To,