New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Nucleus queue when removing an element #179

Open
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@norchow
Contributor

norchow commented Aug 1, 2018

This was generating big memory leaks when creating and replacing
several components permanently.

norchow added some commits Aug 1, 2018

Clean Nucleus queue when removing an element
This was generating a big memory leaks when creating and replacing
several components permanently.
@coveralls

This comment has been minimized.

coveralls commented Aug 1, 2018

Coverage Status

Coverage decreased (-1.0%) to 85.086% when pulling 5719eb5 on bitex-la:unqueue-removed-components into 6ed18a0 on intercellular:develop.

@norchow

This comment has been minimized.

Contributor

norchow commented Aug 6, 2018

I would need some help with the tests to cover this issue.

Our real use case was like this:
We have 2 lists of ~100 items (rows of a list) each one, and they display near real-time data. So, when trying to re-render all these items over and over again, we discovered there was a memory leak in the Nucleus._queue, because it was not releasing outdated components.

Can anyone help me with the tests for this? I've tried integration, Nucleus and even Phenotype tests, but i cannot reproduce the case in which the components get overwritten either.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment