From dda3d2e3dc297060c853ecbbe5eaa64429763a90 Mon Sep 17 00:00:00 2001 From: Ben Donnelly Date: Thu, 14 Mar 2024 17:54:53 +0000 Subject: [PATCH 1/2] fix(service name): fix missing support for wellknown labels in tag values search --- pkg/deepdb/encoding/vparquet/block_search_tags.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkg/deepdb/encoding/vparquet/block_search_tags.go b/pkg/deepdb/encoding/vparquet/block_search_tags.go index d0962c5..94fab79 100644 --- a/pkg/deepdb/encoding/vparquet/block_search_tags.go +++ b/pkg/deepdb/encoding/vparquet/block_search_tags.go @@ -214,6 +214,13 @@ func searchTagValues(ctx context.Context, tag deepql.Attribute, cb common.TagCal return nil } + if column, ok := wellKnownColumnLookups[tag.Name]; ok { + err := searchSpecialTagValues(ctx, column.columnPath, pf, cb) + if err != nil { + return fmt.Errorf("unexpected error searching special tags: %w", err) + } + } + // Finally also search generic key/values err := searchStandardTagValues(ctx, tag, pf, cb) if err != nil { From 0b91bfc4050d31b4b22e3c603c7ab8411d8f27f7 Mon Sep 17 00:00:00 2001 From: Ben Donnelly Date: Thu, 14 Mar 2024 17:56:17 +0000 Subject: [PATCH 2/2] fix(service name): update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 833d15f..9fa7155 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # main (unreleased) - **[BUGFIX]**: fix missing data in frame response [#89](https://github.com/intergral/deep/pull/89) [@Umaaz](https://github.com/Umaaz) +- **[BUGFIX]**: fix missing support for well known labels [#92](https://github.com/intergral/deep/pull/92) [@Umaaz](https://github.com/Umaaz)